issues
search
project-serum
/
sol-wallet-adapter
Other
185
stars
92
forks
source link
To ts
#35
Closed
Arrowana
closed
3 years ago
Arrowana
commented
3 years ago
Concerns:
We use to resolve
Error
or
string
, but
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject
suggests it should be
Error
only
Typing could be improved to avoid the many
any
but that is a start
null
handling should be better instead of silently do nothing
Concerns:
Error
orstring
, but https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject suggests it should beError
onlyany
but that is a startnull
handling should be better instead of silently do nothing