Closed secretshardul closed 3 years ago
Travis linting error has been resolved.
Awesome.
The new theme styling makes the component noticeably more cramped in the web ui. Is there a way to make these changes map more closely to the current component styling? For example, make it a little wider, taller, etc.
Awesome.
The new theme styling makes the component noticeably more cramped in the web ui. Is there a way to make these changes map more closely to the current component styling? For example, make it a little wider, taller, etc.
Took some creative liberty haha, so the design deviated a bit. Here's what I plan:
swapTokenSelectorContainer
.I like the larger token icons, but should I revert that as well?
Awesome. The new theme styling makes the component noticeably more cramped in the web ui. Is there a way to make these changes map more closely to the current component styling? For example, make it a little wider, taller, etc.
Took some creative liberty haha, so the design deviated a bit. Here's what I plan:
- Taller: Add vertical padding
- Wider: Add horizontal padding, increase width of
swapTokenSelectorContainer
.I like the larger token icons, but should I revert that as well?
I don't hate the new styling. Just want to make sure that if we change it, we do it with intention. Let's keep the styling the same for now, address the mobile responsiveness here, and we can consider changing sizes in a subsequent PR.
Updated
Awesome. The new theme styling makes the component noticeably more cramped in the web ui. Is there a way to make these changes map more closely to the current component styling? For example, make it a little wider, taller, etc.
Took some creative liberty haha, so the design deviated a bit. Here's what I plan:
- Taller: Add vertical padding
- Wider: Add horizontal padding, increase width of
swapTokenSelectorContainer
.I like the larger token icons, but should I revert that as well?
I don't hate the new styling. Just want to make sure that if we change it, we do it with intention. Let's keep the styling the same for now, address the mobile responsiveness here, and we can consider changing sizes in a subsequent PR.
Updated to reflect original styling.
The original example code was not in the exact centre. This has been resolved, so you may notice a rightwards shift. Here's what happens when width is increased in the old version.
Fixed it in the same commit for it was breaking responsiveness on mobile screens.
Rebased on master.
The changes didn't quite restore the original UI dimensions. So I went ahead and used your original spacing parameters.
The current code uses hardcoded CSS dimensions which break responsiveness on mobile. They have been replaced by
theme.spacing()
for adaptive resizing.Screenshots
Mobile
Desktop