search

project-serum / swap-ui

React Component for Swapping on the Serum DEX
Apache License 2.0
113 stars 117 forks source link

Added common token bases #88

Open munanadi opened 3 years ago

munanadi commented 3 years ago

Wrt. #56

commonBases?: <PublicKey[]> is a prop that can be passed on to the <Swap> This will show up on top of the list.

The star icon in the token list lets users select their own custom base token apart from the customBases passed as a prop. The icon also acts like a toggle that reflects the state change also updating local storage.

add remove token bases

I also fixed unnecessary rerenders of TokenDialog. For example it was rendering even when it was not displayed on screen. Hence used the showTokenDialog bool to trigger its render only when its shown.

This is before using the fix. bad

This is after we use useMemo to only render when the list is shown good

This makes the UI a bit faster preventing rerenders. and the UX a little better I hope. Let me know what you think! :))

munanadi commented 3 years ago

I did run yarn lint:fix and nothing changes. works fine. any suggestions?

secretshardul commented 3 years ago

yarn lint is behind failed check. Change formatting so yarn lint shows no errors.

https://app.travis-ci.com/github/project-serum/swap-ui/builds/238231690#L239

secretshardul commented 3 years ago

Merged with cyclos-prod