project-slippi / Ishiiruka

GNU General Public License v2.0
330 stars 142 forks source link

Playback build doesn't immediately end when netplay build is running next to it #338

Open FluentCoding opened 2 years ago

FluentCoding commented 2 years ago

Expected Behavior

The main thread of the playback build should stop immediately when being closed.

Current Behavior

When closing the playback build while the netplay build is running next to it, it takes around 10 seconds for the process to stop. You can see this if you follow the steps below with a task manager. This issue originated from: https://github.com/project-slippi/slippi-launcher/issues/231.

Steps to Reproduce

  1. Open the netplay build (through configure netplay build in the slippi launcher e.g.)
  2. Open the playback build
  3. Close the playback build (and you will notice in the task manager that the process is still running for around 10 seconds until it closes itself, except for if you follow step 4 without waiting)
  4. Close the netplay build (which results into both processes being stopped immediately)

Environment

Windows 10 Home 64-bit Slippi Launcher to open both dolphin builds

Video

The included video shows the step to reproduce the issue in two ways, 1. with waiting for the playback build process to automatically end after closing it and 2. without waiting and closing the netplay build before the playback build process automatically ends.

https://user-images.githubusercontent.com/33455186/153748026-84a7fae5-62ed-4366-adac-05037797b06a.mp4