search

project-slippi / Ishiiruka

GNU General Public License v2.0
330 stars 142 forks source link

Move User folder to Application Support on macOS. #374

Closed ryanmcgrath closed 1 year ago

ryanmcgrath commented 1 year ago

This makes Ishiiruka store the User folder in ~/Library/Application\ Support/com.project-slippi.dolphin/User/ rather than inside the application bundle. In truth, Apple has always warned that storing things in a bundle could invalidate the signature, but in practice it hasn't been an issue... until Ventura. This, coupled with a Launcher update, should fix the "damaged app" issue I think.

Tested and playing/etc works fine (tested with reinstalls as well) but probably needs more testing/pairs of eyes. I believe this is the sole place that needs to be changed but I'm open to being wrong.

ryanmcgrath commented 1 year ago

(The "app is damaged" bug is exhibited on Ventura due to the bundle being changed, as GateKeeper now verifies the signature each time, not just on-first-run.)