project-slippi / Ishiiruka

GNU General Public License v2.0
329 stars 140 forks source link

Add Slippi option to use port mapping via UPnP and NAT-PMP #388

Open jmlee337 opened 1 year ago

jmlee337 commented 1 year ago

In cases where UPnP or NAT-PMP are available, enabling this option will improve connecting to other players while behind symmetric NAT. Regardless of own NAT type, it may also help connecting with other players who are behind symmetric NAT.

Note that while we don't specifically use PCP, NAT-PMP is literally PCP version 0 and routers which nominally support only PCP may be backward compatible.

While there are some security concerns with UPnP, all 3 major consoles support it and we literally already tell users who have connection problems to enable it on their router if possible (!connect)

There's also a possibly of using port mapping to improve connections for players who are behind the same CGNAT/double NAT in the future.