search

project-slippi / Ishiiruka

GNU General Public License v2.0
330 stars 142 forks source link

appimage does not seem to include libmpg123 #410

Open michaelBelsanti opened 1 year ago

michaelBelsanti commented 1 year ago

The appimage seems to require libmpg123 to run the appimage.

Expected Behavior

This library is not in the appimage excludelist, so it should be included.

Current Behavior

Trying to run without it results in the error: undefined symbol: mpg123_info2.

Steps to Reproduce

Run the appimage on a distro that does not include have this package installed, or a distro that sandboxes binaries.

Environment

I tested this on NixOS with appimage-run. I also tested it on a fresh Fedora container.

NikhilNarayana commented 1 year ago

I cannot reproduce this on Ubuntu 20.04 (my dev env) or Fedora 38 (live boot)

I will note that we use an old linuxdeploy for packaging because of issues we saw on Fedora, but i should test to see if those are fixed

michaelBelsanti commented 1 year ago

Fedora, and I would assume Ubuntu, come with this library installed since parts of GNOME depend on it. Most standard distros would, but it's possible that some minimal ones wouldn't. I noticed the problem on NixOS because appimages are run using appimage-run, which is sandboxed to only access the libraries included in the exclude list.

I'm not very familiar with packaging AppImages, but I'll try building it myself tonight to see if I can identify why this dependency is getting left out. It may be an issue with linuxdeploy. It might also make sense for it to be added to the exclude list, since many other multimedia libraries are in it.