search

project-slippi / Ishiiruka

GNU General Public License v2.0
330 stars 142 forks source link

ENABLE_HEADLESS=ON causes wx/bitmap.h: No such file or directory #412

Open IAmAbszol opened 1 year ago

IAmAbszol commented 1 year ago

Issue tracker is ONLY used for reporting bugs. Please use our discord for support and/or feature requests.

When pulling latest of and building the application on Ubuntu 22.04 using the cmake .. -DENABLE_HEADLESS=ON flag an error is hit when building:

In file included from /home/kyle/Storage/Projects/MeleeSetup/tmp/Ishiiruka/Source/Core/Core/HW/EXI_DeviceSlippi.cpp:41:
/home/kyle/Storage/Projects/MeleeSetup/tmp/Ishiiruka/Source/Core/DolphinWX/Frame.h:11:10: fatal error: wx/bitmap.h: No such file or directory
   11 | #include <wx/bitmap.h>

Expected Behavior

The build should pass and generate a headless dolphin executable.

Current Behavior

The error above is raised. This is because wxWidgets_LIBRARIES has been disabled with the -DENABLE_HEADLESS=ON flag set and DolphinWX/CMakeLists.txt doesn't have any headers to work with.

Steps to Reproduce

  1. git clone --recursive https://github.com/project-slippi/Ishiiruka.git
  2. mkdir build
  3. cmake .. -DENABLE_HEADLESS=ON && make -j1
  4. PROFIT

Environment

ericyuegu commented 5 months ago

Getting the exact same thing on Ubuntu 20.04: 

In file included from /opt/projects/slippi-Ishiiruka/Source/Core/Core/HW/EXI_DeviceSlippi.cpp:41:
/opt/projects/slippi-Ishiiruka/Source/Core/DolphinWX/Frame.h:11:10: fatal error: wx/bitmap.h: No such file or directory
   11 | #include <wx/bitmap.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
IAmAbszol commented 5 months ago

Getting the exact same thing on Ubuntu 20.04:

In file included from /opt/projects/slippi-Ishiiruka/Source/Core/Core/HW/EXI_DeviceSlippi.cpp:41:
/opt/projects/slippi-Ishiiruka/Source/Core/DolphinWX/Frame.h:11:10: fatal error: wx/bitmap.h: No such file or directory
   11 | #include <wx/bitmap.h>
      |          ^~~~~~~~~~~~~
compilation terminated.

Try my other repository for Docker slippi that uses Vladfi's slippi to run in headless: https://github.com/IAmAbszol/docker-slippi/tree/develop

There's also a regular slippi instance it can create for non-headless to evaluate and potentially even just play melee.

vladfi1 commented 5 months ago

This is fixed on my exi-ai-rebase branch.