search

project-slippi / Ishiiruka

GNU General Public License v2.0
330 stars 142 forks source link

add `-p`/`--slippi-port` cmd line option for spectate server port #421

Closed jmlee337 closed 5 months ago

jmlee337 commented 5 months ago

fixes #419

this will allow developers to connect to the spectate server on multiple dolphin instances on the same machine

jmlee337 commented 5 months ago

looks like there's a precedent for 'slippi spectate' as in SlippiSpectateServer: https://github.com/project-slippi/Ishiiruka/blob/a9c5519a7bf7122e1d11fde7499538af988cac1c/Source/Core/Core/Slippi/SlippiSpectate.h#L39 is this ok?

NikhilNarayana commented 5 months ago

looks like there's a precedent for 'slippi spectate' as in SlippiSpectateServer:

https://github.com/project-slippi/Ishiiruka/blob/a9c5519a7bf7122e1d11fde7499538af988cac1c/Source/Core/Core/Slippi/SlippiSpectate.h#L39 is this ok?

not necessarily against it, but i would like the corresponding config value to be renamed to match so it is easy to match them up, if you prefer just spectate

jmlee337 commented 5 months ago

oh the config name lol oops. No I'll go spectator I don't want to change the config name that could be breaking if people are touching it programmatically