search

project-slippi / Ishiiruka

GNU General Public License v2.0
329 stars 140 forks source link

fix: update lib name to slippi_rust_extensions for Cargo 1.79 compat #424

Closed pylasnier closed 1 month ago

pylasnier commented 2 months ago

Cargo 1.79 breaks Linux build by replacing dashes with underscores in cargo metadata causing corrosion to generate incorrect lib names in CMake files before corrosion v0.5.0.

This just changes the lib name to use underscores instead of dashes to avoid any confusion.

pylasnier commented 2 months ago

this works as expected, however the changes to SlippiRustExtensions should be PR'd in https://github.com/project-slippi/slippi-rust-extensions and this repo's PR should update to the latest commit in main once the former is merged

Have now submitted the PR to the submodule upstream. I will update the commit here once it's merged