search

project-slippi / dolphin

Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.
https://dolphin-emu.org/
Other
15 stars 8 forks source link

Memory leak that causes crashes after prolong play #13

Open MrCoolSponge opened 7 months ago

MrCoolSponge commented 7 months ago

Expected Behavior

When the game is running system memory usage should stay at a reasonable level

Current Behavior

The emulator will consistency get up to 10+ gigabytes after running for 10 to 20 minutes

Steps to Reproduce

  1. https://youtu.be/ObTEK9WboPU Video of the memory leak in action. There is a crash at 1:55
  2. By the end of the 14 minute video the emulator is taking up 4.3 gigabytes of system memory
  3. It could get MUCH higher (up to 11 gigabytes)

Environment

Windows 10 Ryzen 7 7700X GTX 1060 6GB 32GB of DDR5-6000 Ram Direct3D 11 4x Native

NikhilNarayana commented 7 months ago

@MrCoolSponge does this happen on the stable (Ishiiruka) Dolphin as well? do you have custom textures enabled/are you using a non-vanilla ISO? Can you provide screenshots of all the Dolphin graphics settings?

MrCoolSponge commented 7 months ago

@NikhilNarayana Sorry for placing the issue in the wrong repo No this memory leak does not happen on the Ishiiruka build I have never installed custom textures and I am using the same stock ISO I have been using since slippi lunched in 2020 image image image image Here are all the graphics settings, I can also post all the properties but I literally have not touched any of them One more thing about the leak, it happens even when just sitting ideal on the start screen (even before starting any matches) If you want/need any more info about my set up please let me know edit: missed some settings in my screenshots image

ryanmcgrath commented 7 months ago

Could you enable all logs (View -> Logs / Log Viewer), set the level to info, and run the game then collect the logs? There's an option to dump to a file, wondering if there's anything that could be gleaned from there as well.

MrCoolSponge commented 7 months ago

@ryanmcgrath Here is my logs for a single online game + just sitting at character select The Ram usage got up to 1.6 gigs dolphin.log

NikhilNarayana commented 6 months ago

@MrCoolSponge can you give the latest release a try? that'd somewhat help me narrow down the issue

MrCoolSponge commented 6 months ago

@NikhilNarayana Just check the latest version, leak is still happening Here are the new logs, got up to 2 gigabytes in about 6 matches

The stable release has not been giving me any memory leaks dolphin.log

NikhilNarayana commented 6 months ago

@MrCoolSponge thanks for that update. could you also test official Dolphin?

https://dl.dolphin-emu.org/builds/24/4e/dolphin-master-5.0-21088-x64.7z

MrCoolSponge commented 6 months ago

@NikhilNarayana Official does not leak.

Tried both Melee and Tony Hawks pro 3 and there was no memory leak (at least not one the filled the ram with gigabyte of junk)

I also tried uncle punch training mod on this current slippi dolphin fork, the leak happened in that mod as well.

One thing I wanted to check is to see if the leak happened in a game other then melee, and I couldn't load any other games. It just says "failed to init core" and closes the game window. Not sure if that is normal, never tried playing other games on this fork of dolphin.

If you want the dump from the official dolphin version (the one that doesn't leak) or anything else then just tell me.