search

project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
147 stars 78 forks source link

[PR] Correctly Calculate Winners for Timeout #123

Closed JLaferri closed 1 year ago

JLaferri commented 1 year ago

This fetches the final post frame updates and checks the stocks and percents on the last frame in the case of a timeout.

JLaferri commented 1 year ago

Looking good for the most part just a few questions and comments. Were you also intending to add a test? I noticed you added an SLP file in the placementsTest but no accompanying test.

Good catch, I had accidentally deleted the test. It's back now