search

project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
148 stars 79 forks source link

Parse instance id info #124

Closed NickCondron closed 1 year ago

NickCondron commented 1 year ago

This PR is intended to parse instance id data added by https://github.com/project-slippi/slippi-ssbm-asm/pull/120

Here is what a ~10 second match against a CPU looks like when you print all the post-frame/item updates and their relevant instance id info:

https://pastebin.com/5zP8MdgB

As mentioned in the other PR these fields can be used to better track hits in doubles because lastHitBy field is unreliable (https://github.com/project-slippi/slippi-js/pull/71).

NickCondron commented 1 year ago

Small PR hoping to get it merged now that the instance fields are released

vinceau commented 1 year ago

@NickCondron Do you mind adding a test and a minimal SLP (if an SLP containing the data to test doesn't already exist)?