search

project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
148 stars 79 forks source link

Fixed jab reset detection in combos #125

Closed Walnut356 closed 1 year ago

Walnut356 commented 1 year ago

As noted by Lunar Melee, jab resets aren't picked up by the combo/conversion computers. There's also some false-detection around mangifying-glass damage.

Jab reset states added to isDamaged should take care of the former, the latter is finnicky.

An alternative solution that would fix both would be to check the hitstun (or defender hitlag) bitflag. Doing so would require replays of at least version 2.0.0, so I've held off for now in case I think of something with better compatibility.

vinceau commented 1 year ago

hey mate, thanks for this PR but your build is failing so you probably need to first run yarn run lint --fix to before CI will pass