search

project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
148 stars 79 forks source link

Add missing fields to MetadataType interface #47

Closed jmlee337 closed 3 years ago

jmlee337 commented 3 years ago

MetadataType.players[].names appears in replay files from netplay and is documented in the replay spec, but does not appear in the MetadataType interface.

Add the field to the interface and add a test to read it

jmlee337 commented 3 years ago

I also found that consoleNick was missing from MetadataType