project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
148 stars 79 forks source link

Use strict mode and fix typings #49

Closed vinceau closed 3 years ago

vinceau commented 3 years ago

There's almost no reason to Typescript without using strict mode and strictNullChecks.

This PR enables strict mode and strictNullChecks which causes a whole bunch of typing issues. A lot of these issues we're just using a non-null assertion for now to mitigate. Should properly handle the non-null case in a future PR. Maybe #48 could be updated to handle more of those lint warnings.

Additionally, we stop erroring upon invalid character and invalid stage.