project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
147 stars 78 forks source link

check the tests folders with eslint not just src, fix existing errors #68

Closed DustinAlandzes closed 3 years ago

DustinAlandzes commented 3 years ago

This pull requests adds the test folder to be checked by eslint

commandByte and metadata are unused variables

and this line gave me the "strict-booleans/no-nullable-numbers" error https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/strict-boolean-expressions.md

const lastFrame = metadata.lastFrame || game.getLatestFrame().frame;

101:23 error Unexpected nullable number value in conditional. Please handle the nullish/zero/NaN cases explicitly strict-booleans/no-nullable-numbers

vinceau commented 3 years ago

Superseded by 0e0c3a2