search

project-slippi / slippi-js

Parse slp files and compute stats
GNU Lesser General Public License v3.0
148 stars 79 forks source link

Why are the stageIds missing numbers? #70

Closed PMcca closed 3 years ago

PMcca commented 3 years ago

I've noticed the stageIds are missing numbers, visible in the enums too (see melee/types.js). The numbers missing are 0, 1 and 21 weirdly.

What is the reason for this? What prevented/prevents the stageIds from being enumerable and in complete sequence?

yashichidsf commented 3 years ago

https://docs.google.com/spreadsheets/d/1JX2w-r2fuvWuNgGb6D3Cs4wHQKLFegZe2jhbBuIhCG8/preview#gid=20 they are not valid, normally accessible stages. Dummy (0), TEST (1), and Akaneia (21)

NikhilNarayana commented 3 years ago

Those are from the game and you can see a full list of stages here: https://docs.google.com/spreadsheets/d/152A_UrA996o5VXveCkfJVPVuVBHP-90HxdkU72m0Ioc/edit#gid=20

Those specific ones are just not needed by us so we don't include them.

For future questions that aren't slippi-js bugs or such, please use our discord.

PMcca commented 3 years ago

Thanks, v helpful to know