Add stadium support - Githubissues

project-slippi / slippi-js

Parse slp files and compute stats

GNU Lesser General Public License v3.0

147 stars 78 forks source link

Closed cnkeats closed 1 year ago

cnkeats commented 2 years ago

This PR expands many aspects with the goal of adding support to the Slippi Launcher for the Target Test and Home-Run Contest game modes.

Adds frameToGameTimer() in utils for converting a frame number to the in-game timer value for that frame
Greatly expands the game info block in getSettings()
Adds more ids for various 1-player stages
- Replays for event stages can be found in #91
Adds more ids for various game modes with a test for verification

JLaferri commented 1 year ago

This PR looks okay to me for the most part. But I'm interested to know what @JLaferri thinks about exhaustively expanding all these constants.

I don't mind it, I think it's probably better to have more info than less. That said, it looks like there's a few breaking changes? Field names have changed. Example: https://github.com/project-slippi/slippi-js/pull/93/files#diff-c54113cf61ec99691748a3890bfbeb00e10efb3f0a76f03a0fd9ec49072e410aR69

So we'd probably need to increase the major version number.