search

project-slippi / slippi-launcher

The way to play Slippi Online and watch replays.
GNU General Public License v3.0
246 stars 127 forks source link

opening two configuration dolphins blocks a close event from triggering #231

Open NikhilNarayana opened 3 years ago

NikhilNarayana commented 3 years ago

I noticed a very weird interaction where if you open two dolphins for configuring, the close event of the dolphin opened second won't trigger until you close the dolphin you opened first. This doesn't happen when you launch netplay and a replay.

Steps to repro:

  1. Add some log statements in the close events for configuration dolphins.
  2. Configure a Netplay Dolphin.
  3. Configure a Playback Dolphin.
  4. Close Playback Dolphin, notice that the log message doesn't show up.
  5. Close Netplay dolphin, notice that the log message for netplay shows up immediately and then the log message for playback shows up.
FluentCoding commented 2 years ago

I looked into this issue and it apparently seems like the main thread of the playback dolphin build doesn't end even if you close the application, so I suppose that this issue has nothing to do with the slippi launcher itself. (see the lower task of the image which is the result of following every step up to step 4)

image