project-slippi / slippi-launcher

The way to play Slippi Online and watch replays.
GNU General Public License v3.0
241 stars 125 forks source link

Extra SLP directories with substring of root directory can't be added #359

Closed NikhilNarayana closed 1 year ago

NikhilNarayana commented 1 year ago

Attempting to add an adjacent directory that contains the root directory path a substring will result in Cannot add sub directories of the Root SLP Directory. error. Users should be able to add these directories since there isn't a real conflict.

Example: Root = C:\Users\Nikki\Documents\Slippi Adding C:\Users\Nikki\Documents\Slippi Test will result in the error mentioned above.

dryu99 commented 1 year ago

Hey I can take this on! I've already whipped up a local branch, just need collaborator permissions for the repo to push to a remote branch and then I'll make a PR 👍

Ignore that last bit, I just joined the Discord and saw that forks are preferred vs branches 👌