Closed hallyn closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d54e250
) 57.10% compared to head (d9cb119
) 57.12%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
not ok 66 import various sizes in 4sec
@rchincha is this a regression in this test? (i don't see how it could be, but...) Or has it been seen elsewhere?
The following:
stacker build --substitute a=b,c
used to work, until commit 3baba644:
fix(ci): convert ci is failing due to perms (#439)
This squashed PR included 'chore(go.mod): update cli to github.com/urfave/cli/v2'. Switching from urfave/cli/v1 to v2 changes string slice flag behavior to automatically split on commas.
Luckily there is an app.DisableSliceFlagSeparator flag we can set to tell it not to do that. Set that flag. And add a test for this.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.