project-stacker / stacker

Build OCI images natively from a declarative format
https://stackerbuild.io
Apache License 2.0
208 stars 34 forks source link

fix: don't break on --substitute values which have commas #580

Closed hallyn closed 10 months ago

hallyn commented 10 months ago

The following:

stacker build --substitute a=b,c

used to work, until commit 3baba644:

fix(ci): convert ci is failing due to perms (#439)

This squashed PR included 'chore(go.mod): update cli to github.com/urfave/cli/v2'. Switching from urfave/cli/v1 to v2 changes string slice flag behavior to automatically split on commas.

Luckily there is an app.DisableSliceFlagSeparator flag we can set to tell it not to do that. Set that flag. And add a test for this.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d54e250) 57.10% compared to head (d9cb119) 57.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #580 +/- ## ========================================== + Coverage 57.10% 57.12% +0.01% ========================================== Files 64 64 Lines 7519 7521 +2 ========================================== + Hits 4294 4296 +2 Misses 2483 2483 Partials 742 742 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hallyn commented 10 months ago

not ok 66 import various sizes in 4sec

@rchincha is this a regression in this test? (i don't see how it could be, but...) Or has it been seen elsewhere?