project-stacker / stacker

Build OCI images natively from a declarative format
https://stackerbuild.io
Apache License 2.0
208 stars 34 forks source link

feat: add namespace arg when producing doc #588

Closed rchincha closed 9 months ago

rchincha commented 9 months ago

Currently, stacker-bom doesn't include namespace information in the document. Adding a cmdline arg to do so.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (710a944) 13.02% compared to head (f4176e0) 57.15%. Report is 1 commits behind head on main.

Files Patch % Lines
pkg/types/layer.go 0.00% 2 Missing and 1 partial :warning:
cmd/stacker/bom.go 66.66% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## =========================================== + Coverage 13.02% 57.15% +44.13% =========================================== Files 40 64 +24 Lines 6059 7525 +1466 =========================================== + Hits 789 4301 +3512 + Misses 5138 2481 -2657 - Partials 132 743 +611 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.