Closed rchincha closed 6 months ago
Thanks for fixing my testcase - I'm sorry, I hadn't noticed that I had uploaded an older copy of my tree. I had actually just switched to using docker://busybox:latest, but what you have here is great.
So as we discussed in the debug session - I think overlay is working just fine (we should verify this by also doing the test with --layer-type=overlay in the testcase). I think the tar file is breaking because overlay is not creating /.wh_ccc when it has /ccc with contents and overlay.opaque=y. When we only rm -rf /bbb, then it does create /.wh_bbb.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.49%. Comparing base (
b585bfb
) to head (f54ee9a
). Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.