search

project-sunbird / sunbird-cloud-storage-sdk

MIT License
1 stars 32 forks source link

gcp signed url fix #45

Closed shishirsuman092 closed 1 year ago

shishirsuman092 commented 1 year ago

@maheshkumargangula I have resolved all the comments raised as per review. Kindly merge it to the repo.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

maheshkumargangula commented 1 year ago

These changes related to https://github.com/orgs/Sunbird-Ed/discussions/318#discussioncomment-4763643.

maheshkumargangula commented 1 year ago

@shishirsuman092 – Please make the same changes for Scala 2.11 and Java 8 using the below branch. https://github.com/project-sunbird/sunbird-cloud-storage-sdk/tree/scala-2.11-with-latest Cc: @mathewjpallan