Open TableCafe opened 4 years ago
I have:
Additional Information (Steps to reproduce/Expected behavior) :
Empyrean aftermaths do not give the proper proc chance of 30%, 40%, 50% for the three tiers of TP.
https://www.bg-wiki.com/bg/Empyrean_Aftermath
https://github.com/project-topaz/topaz/blob/9c8ca0c0c5f4c8dc98bc9deb9d72c0d4ebad59b1/src/map/utils/attackutils.cpp#L164-L169
based on the code in attackutils.cpp the mod power is divided by 10, meaning the power in the aftermath LUA needs to be increased by a factor of 10 in order to give the proper proc rate.
https://github.com/project-topaz/topaz/blob/9c8ca0c0c5f4c8dc98bc9deb9d72c0d4ebad59b1/scripts/globals/aftermath.lua#L185-L204
In my testing the current setup gives us a 3%, 4%, 5% proc rate.
Somebody forgot we use 1000 to represent 100% so that we can hand partial percentage points like 12.5%
I have:
Additional Information (Steps to reproduce/Expected behavior) :
Empyrean aftermaths do not give the proper proc chance of 30%, 40%, 50% for the three tiers of TP.
https://www.bg-wiki.com/bg/Empyrean_Aftermath
https://github.com/project-topaz/topaz/blob/9c8ca0c0c5f4c8dc98bc9deb9d72c0d4ebad59b1/src/map/utils/attackutils.cpp#L164-L169
based on the code in attackutils.cpp the mod power is divided by 10, meaning the power in the aftermath LUA needs to be increased by a factor of 10 in order to give the proper proc rate.
https://github.com/project-topaz/topaz/blob/9c8ca0c0c5f4c8dc98bc9deb9d72c0d4ebad59b1/scripts/globals/aftermath.lua#L185-L204
In my testing the current setup gives us a 3%, 4%, 5% proc rate.