search

project-topaz / topaz

Server emulator for FFXI
Other
159 stars 224 forks source link

Nation rank bar needs multiplier #1270

Open MarianArlt opened 3 years ago

MarianArlt commented 3 years ago

I have:

Additional Information (Steps to reproduce/Expected behavior) : I think everyone has noticed how the rank points gained by trading in crystals is very legacy like where you had to trade full stacks of crystals to advance to the next mission even on Rank5/6ish. This is very out of sync with most recent guides that say "trade 1 crystal", "trade 3 crystals" etc. But even if you raised the amount of rank points added by trading in crystals, you'd still have to trade a decent amount because the missions itself have seen no increase. Retail has seen a very flat 2x multiplier for rank bar increase, be it by trading crystals or by doing missions. I can not speak for CP gain though when the rank is full, which shall not be the matter of this issue.

This is extremely easy to test and anybody with doubts can create a free trial account, do missions up to Rank 2 and do what I (and people before me) did:

  1. With Rank 2 and bar empty trade 1 crystal to a guard that is not light or dark (talks on wiki pages seem to show that they do yield higher gains, I also think to recall this to be the case from back in the days; I chose wind)
  2. Make a screenshot and measure the pixels of the bar after trading one crystal
  3. Trade another crystal, make a screenshot and measure the total pixels of the bar now
  4. Repeat 3.
  5. Do Mission 2-1 for your nation, do a screenshot and measure the pixels after doing the mission.
  6. Repeat 1-5 on Topaz

topaz_retail_rank_bar_difference

According to resolution and compression/quality levels of the client there might be 1px off here and there, but I think this demonstrates very clearly that SE didn't put an overload of paid hours into overthinking this and added a plain 2-times multiplier.

I therefore suggest a simple multiplier of 2 for any rank bar gain in: https://github.com/project-topaz/topaz/blob/abfe5dda545545f060a761e894c79d55239ada02/src/map/lua/lua_baseentity.cpp#L6113-L6132

This multiplier could then be easily reversed to not gain excessive CP in https://github.com/project-topaz/topaz/blob/abfe5dda545545f060a761e894c79d55239ada02/scripts/globals/conquest.lua#L962-L965

TeoTwawki commented 3 years ago

I think everyone has noticed how the rank points gained by trading in crystals is very legacy like where you had to trade full stacks of crystals to advance to the next mission even on Rank5/6ish.

Yeah I had no idea of any change but it used to take multiple stacks to fill the bar for later ranks.. The higher you climbed the more it took, but it you intentionally got the rank bar almost full and then traded 8 stacks of light/dark you got a good deal of CP for it at least in days where CP was actually worth having.

crystal to a guard that is not light or dark (talks on wiki pages seem to show that they do yield higher gains

its relative to the npc resell value, the 6 main sell for less and light/dark for more. Our calculation should use basesell and a multiplier.