New changes to npcutil broke canary trusts

kaincenteno commented 3 years ago

I have:

[x] searched existing issues (http://project-topaz.com/issues/) to see if the issue has already been opened
[x] checked the commit log to see if the issue has been resolved since my server was last updated

Additional Information (Steps to reproduce/Expected behavior) :

Canary is broken due to keyitem flags changing from "keyItem" to "ki" from trust branch. When trying to finish Bastok trust quest, the quest will be completed but keyitem never received. Unsure if there is something else that might break from other branches.

TeoTwawki commented 3 years ago

proposed fix: https://github.com/project-topaz/topaz/pull/1303#discussion_r502866950

zach2good commented 3 years ago

Changed the quests to use ki: https://github.com/project-topaz/topaz/commit/41ee8b2e0d4ece34e29f2e92da61921af39d62e5

Also patched the function to accept keyItem if there are any leftover somewhere: https://github.com/project-topaz/topaz/commit/f828092c6ff49a030f331626bf3ac82e915603e8

project-topaz / topaz

New changes to npcutil broke canary trusts #1411