project-topaz / topaz

Server emulator for FFXI
Other
159 stars 224 forks source link

Enable (and fix) basic warnings on all platforms #1426

Closed zach2good closed 3 years ago

zach2good commented 3 years ago

I affirm:

Clang:

-Wlogical-not-parentheses
Example: !PMob->getMobMod(MOBMOD_NO_DESPAWN) != 0

-Wenum-compare-switch
-Wabsolute-value
Using abs() on an unsigned value (negative isn't possible)

-Wtautological-constant-out-of-range-compare
Checking to see if a condition is true on a type where it isn't possible.  Example: is a uint8 larger than 10000?

-Wnon-virtual-dtor
-Wunused-lambda-capture
-Wmissing-field-initializers
-Wunused-private-field
-Wmissing-field-initializers
zach2good commented 3 years ago

Closing for now, don't have time to do this audit :(