search

project-topaz / topaz

Server emulator for FFXI
Other
159 stars 224 forks source link

Desynths #1447

Closed Dirk-Dieters closed 3 years ago

Dirk-Dieters commented 3 years ago

For this round, I used the following criteria:

1: Item has a specific desynth recipe and yield listed on its BGWiki page (without a level) AND Item has a synthesis recipe 2: Item was previously updated in level but not activated due to yield mismatch.

In cases where the item is craftable, but the desynth recipe had no level assigned to it, the level was set to match the synthesis level, and a comment was added in case future evidence proves that the level should be different.

In cases where the yield shown on FFXIAH/the current database were similar, but not exact matches, (More HQ result information on the BGWiki page primarily), the BGWiki data was used. This includes previously identified mismatched yields, and they have been activated as well.

Some notes: Apparently Desynths aren't a huge priority for the BGWiki contributors, especially smithing, we might have to accept data from FFXIclopedia or another source in order to resolve many of these.

I left comments on several still-disabled recipes that I was unsure about how to proceed.

I affirm:

ibm2431 commented 3 years ago

End of line comments are fine if there's a space after the --. -- This is fine. --This upsets SQL.

Dirk-Dieters commented 3 years ago

I see, thanks

On Thu, Oct 29, 2020, 12:35 PM ibm2431 notifications@github.com wrote:

End of line comments are fine if there's a space after the --. -- This is fine. --This upsets SQL.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/project-topaz/topaz/pull/1447#issuecomment-718943552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRRVPO6UC6B3BEXCGXIOVTSNGYV3ANCNFSM4TC4QRCQ .

Dirk-Dieters commented 3 years ago

Trying to figure out where to go from here, There's a lot of just baseline desynths that are still disabled, but can't be fully justified with only BGWiki and FFXIAH as sources. Do we start accepting FFXIclopedia? If so, do we take it for results, or just levels?

From what I understand, everything craftable should be desynthable at the same level as the craft, so I'll make that the goal of my next PR, but there's not justification for all those recepies on BGWiki, and we already know that FFXIAH doesn't have complete data, so I'll have to do verification from FFXIclopedia or another source.