Add flag to disable timed RoE records + minor fix

Kreidos commented 4 years ago

This patch is good to go into release and should be the last of the straight-to-release fixes. Future PRs will have more recordsets and features which may warrant their own branch once again. :)

Some have mentioned they don't mind RoE, but don't want or don't like the CHALLENGE SPLASH SPAM. These people are crazy, but regardless here's a settings flag to ~~turn just those off~~ turn all timed records off.

I affirm:

[x] that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
[x] that I've tested my code since the last commit in the PR, and will test after any later commits

ibm2431 commented 4 years ago

Do they not want the records period, or just the blaring trumpets?

Kreidos commented 4 years ago

I assume the records themselves too. I didn't think it unreasonable that it be disabled, but I can remove the flag; someone can just edit the timetable to all 0's if they want them off.

ibm2431 commented 4 years ago

Just wanting to make sure the setting does what people expect it to do~!

project-topaz / topaz

Add flag to disable timed RoE records + minor fix #1457