TeoTwawki
commented
3 years ago Some things you should know before reading this pr: multi hit weapons like Joyeuse were already implemented, it was a field in item_weapon table however I do want to see that column die and it migrate to the mod as is done here. Octave club is a good example of why that should be the case.
I'd like to also see the job_multple_lv latents changed slightly: we have a parameter field we can use on a latent. Instead of making it a static 8 for this one item, make it multiple of the specified parameter. Then we don't need a new latent ID used every time we need a different multiple number (there are several right now). MAINJOB_MULTIPLE set param and done.
kaincenteno
MarianArlt
ibm2431
I affirm:
This PR seeks to add: • a latent of name
JOB_MULTIPLE_8for weapons that trigger an effect while the players job is a multiple of 8 (Octave Club) • a modifier of nameADDITIONAL_SWING_CHANCEfor weapons that can trigger an additional attack on top of other multiple hits like Double Attack as a latent. • a modifier of nameMAX_SWINGSfor weapons that increase their hitCount while under a latent effect. • the latent database entry for Octave ClubAs a consequence of this, this PR also had to: • create conditions for the additional swings in
CAttackRound::CreateAttacks()• slightly restructure the conditions of additional swings and how they block each other in that same function • See 4ea931fc3cf1e8db9e73e5982d087af1bee47341 (Mythic Aftermath was not blocked behind Quad/Triple/Double Attack and latent modifiers for OAT not considered)In Detail: • If
MAX_SWINGSexists (should pretty much only be flagged by a latent) it will overwrite the hitCount of that weapon from the database • The default swing now functions as a fallback after all else is considered. This improves recognition of priorities • Quad/Triple/Double attack got their num check removed, they should be rolled in any case, also when a weapon or monster can attack several times. It is the top most priority and does not stack with regular multiple hits or mythic modifiers • Triple/Double attack from Mythic weapons gets rolled after this if Aftermath is in effect • Equipment modifiers from Empyrian armor is then considered • Only if any of these fail will a weapon or monster use regular multiple hits • In preparation for Amood Great Axes a modifier and a condition has been added especially for these, since they do indeed stack • After all these considerations, ammo triggered additional swings from weapons like the Jailer weapons are considered, the check itself has not been changed • All of the above are possible additional swings, care has been taken to make sure they can not stack up to more than 8 hits • At the very end a default hit will always occurThis makes implementation of most weapons that increase their hitCount with a latent or some other effect now possible and secure with these mods. (Although there are extremely few to begin with)
I tested this successfully with the following setups and it works as expected. • RDM99/PLD49 Regular Weapon: one hit Joyeuse: occ. 2-3 hits Kraken Club: occ. 2-8 hits Octave Club: one hit • RDM96/PLD48 Octave Club: occ. 2-8 hits • WAR99/PLD49 Regular Weapon: occ. Double Attack Joyeuse: occ. 2-3 hits with more 2's than 3's Kraken Club: occ. 2-8 hits with a few more 2' than others Octave Club: occ. Double Attack • THF99/PLD49 All of the above in the same manner but with triple attack Justice Sword + Virtue Stones: Successfully triggers an additional hit even on top of Triple Attack, making it 4 hits Vajra + 3000TP Aftermath: occ. 2-3 hits with frequent 2's • SAM99/PLD49 Hardwood Katana + Zanshin: occ. hits again after missing (Zanshin is not a member of the function in question but I wanted to be sure it works) Hardwood Katana + Virtue Stone: stones won't get accidentally get used Hardwood Katana + Zanshin + Triple/Double Attack equip: Zanshin swing stacks
Things I did not implement or I could not figure out but should not be part of this PR: • Empyrian armor modifiers have various effects on attack swings but there is little people talking about whether it stacks or not (for now I think it is sensible to treat the Iga Garb condition that was there as if it was a roll on Double Attack) • Somebody before me who implemented this condition mentioned something about creating a lua function, but it was not very clear what "nitty gritty stuff" refers to. I suppose its the idea of outsourcing these? • I did not implement the missing condition for Dynamis [D] Follow-Up attack chances • Octave Club is probably the only item in the game (?) that checks on two different lvl multipliers at the same time. This simply interferes with how the according latent switch statements are written and neither will flag in that condition. (for now comment the multiplier of 2 out)
I'm well aware that this messes with one of the most basic mechanics of the game. Please take the time to read what I wrote as carefully as I wrote and tested this PR. Much appreciated.