Closed zach2good closed 3 years ago
e
is a pretty common variable convention to me, but maybe it's just my Java and Python experience has poisoned me. stuck_out_tongue
knee deep in the venom of experience, the young'uns need time to build up resistance
I affirm:
NOT YET SANITY TESTED
I set up static analysis with Sonar, and started fixing all the things it complained about. Each commit explains what I'm doing.
The biggest thing is in the Packet System:
session
was poorly named, and shadowed a global session var -> renamed toPSession
CBasicPacket
, which isn't a big deal -CBasicPacket
is just a bag of pointers, but we still shouldn't be doing that in the hot path 🤷♂️ Swapped it for move semantics gubbins