Nokkhi Jinjahl in Sandy while not Rank 1st & causing client crashes

[topaz-bot]

Issue by Heepster03 Friday Jan 06, 2017 at 02:06 GMT Originally opened as DarkstarProject/darkstar - Issue 3628

---

I have:

• [x] searched existing issues (http://github.com/darkstarproject/darkstar - Issue ) to see if the issue I am posting has already been addressed or opened by another contributor
• [x] checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) : 30161206_3

Server Version (type revision in game) : c31bd6b

Source Branch (master/stable) : Master

Additional Information (Steps to reproduce/Expected behavior) : Currently, San d'Oria is 2nd in the conquest and we have the quiver npc, Nokkhi Jinjahl, in Sandy when they shouldn't be. Secondly, this npc after trading 4 stacks of items for quivering, you get a client crash. After logging on, another trading attempt causes another crash, and so forth.

[topaz-bot]

Comment by TeoTwawki Friday Jan 06, 2017 at 07:10 GMT

---

Bet it doesn't crash after the requires I just added reach yer server. But the conquest thing where she's only supposed to be in the nation "winning", that I did not touch. Not it! -runs and hides-

[topaz-bot]

Comment by metalfiiish Thursday Dec 14, 2017 at 00:10 GMT

---

Looks like she should be spawned in Bastok and Sandy but not windurst (my home nation is being discriminated) according to the sql. It looks like the conquest system has a method to update NPC's based off conquest position but only by region, not per city. I might look to implement a similar function for the main cities to update these types of NPC's.

Listing other NPC's we should implement this behavior for: Besides Regional Merchants, the 1st place Allegiance will have the following NPCs available in its city: Nokkhi Jinjahl, Ominous Cloud, Valeriano, Mokop-Sankop, Cheh Raihah, Nalta and Dahjal. If there is a draw or a 1st place Alliance, those NPCs won't be available.

http://ffxiclopedia.wikia.com/wiki/Category:Conquest

It does look like regional Merchants are coded so it would just be toggling status of the above NPC's.