project-topaz / topaz

Server emulator for FFXI
Other
157 stars 222 forks source link

RoE Expansion 4 #1514

Closed Kreidos closed 3 years ago

Kreidos commented 3 years ago

Adds another 60 or so records, but more importantly this new logic should cover a **huge** number of the remaining records. Those contributors who have expressed an interest in adding to the list of available records, now would be a great time as there are easily hundreds which can be implemented. If interested, please message me on the Discord (Kreidos) and let me know what sections you'd like so we can all work together to avoid duplication of effort. :smiley:

To whoever reviews & merges might not be a bad plan to give this a feature branch and canary time, as there is new logic as well as a potential future landrush for new records that could probably benefit from some testing.

New:

Core work + Fixes:

I affirm:

zach2good commented 3 years ago

I've removed the references to pepe the frog from this PR. While obviously not meant that way here, that meme has a lot of linkage to very hateful things and I don't want it anywhere near the project.

Targetting a new feature branch, will do proper review tomorrow. (and I'll hold off on making a release until tomorrow so this has a chance to make it in)