Sneak + Invis high resale price to guild

project-topaz / topaz

Server emulator for FFXI

Other

157 stars 222 forks source link

Sneak + Invis high resale price to guild #1527

Closed kaincenteno closed 3 years ago

kaincenteno commented 3 years ago

I have:

[x] searched existing issues (http://project-topaz.com/issues/) to see if the issue has already been opened
[x] checked the commit log to see if the issue has been resolved since my server was last updated

Additional Information (Steps to reproduce/Expected behavior) :

This was reported on Canaria by RedQueen, you can abuse buying the items from curio vendor moogle and resale them to guildshop for profit.

ibm2431 commented 3 years ago

Please confirm this issue exists yourself.

We require exact items and sale process.

As currently reported, this should not be possible.

https://github.com/project-topaz/topaz/blob/release/src/map/items/item_shop.cpp#L89-L98

INSERT INTO `item_basic` VALUES (4164,0,'pinch_of_prism_powder','prism_powder',12,1540,33,0,350);
INSERT INTO `item_basic` VALUES (4165,0,'pot_of_silent_oil','silent_oil',12,1540,33,0,300);

ibm2431 commented 3 years ago

I'm giving someone an opportunity to convince me to not just set sell prices to 0 across the board. These guild shops are incredibly broken, I'm sick of hearing about them, and I'm not planning to spend further time on them.

https://github.com/project-topaz/topaz/blob/release/src/map/utils/guildutils.cpp#L110

https://github.com/project-topaz/topaz/blob/release/sql/guild_shops.sql#L569-L570