project-topaz / topaz

Server emulator for FFXI
Other
158 stars 223 forks source link

DRG Attack, defense, job ability haste buffs when Wyvern is out? #157

Open topaz-bot opened 4 years ago

topaz-bot commented 4 years ago

Issue by ghost Thursday Feb 23, 2017 at 05:55 GMT Originally opened as DarkstarProject/darkstar - Issue 3744


I have:

Client Version (type /ver in game) : version 30161227_1

Server Version (type revision in game) : Unknown

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) : From BGWiki: https://www.bg-wiki.com/bg/Call_Wyvern

"While alive the Wyvern gives a variety of effects to the Dragoon.

20% Attack Bonus
20% Defense Bonus
10% Job Ability Haste

... Attack Bonus and Defense Bonus potency begins at 10% but increases by 2% each time the Wyvern's 'attributes increase' for a maximum of 20%, the Haste effect begins at 0% but likewise increases in increments of 2% until it reaches 10%. Source: http://forum.square-enix.com/ffxi/threads/43912-dev1229-Job-Adjustments"

I could be really wrong about this, but it seems simple to do like addMod(MOD_ATTP) to player after call wyvern and delete them after dismiss/wyvern's death? Oh.. but the increments...hmm

topaz-bot commented 4 years ago

Comment by teschnei Thursday Feb 23, 2017 at 06:06 GMT


It is as you think, fairly simple - the flat bonus would be added on summon and deleted on dismissal, and the increments would be added when the wyvern levels up, and then deleted when dismissed (of course, keeping track of the number of times it levelled up)

On Wed, Feb 22, 2017 at 10:55 PM, soupcans wrote:

I have:

  • searched existing issues (http://github.com/darkstarproject/darkstar/ issues/ <github/darkstarproject/darkstar - Issue >) to see if the issue I am posting has already been addressed or opened by another contributor
  • checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) : version 30161227_1

Server Version (type revision in game) : Unknown

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) : From BGWiki: https://www.bg-wiki.com/bg/Call_Wyvern

"While alive the Wyvern gives a variety of effects to the Dragoon.

20% Attack Bonus 20% Defense Bonus 10% Job Ability Haste

... Attack Bonus and Defense Bonus potency begins at 10% but increases by 2% each time the Wyvern's 'attributes increase' for a maximum of 20%, the Haste effect begins at 0% but likewise increases in increments of 2% until it reaches 10%. Source: http://forum.square-enix.com/ffxi/threads/43912-dev1229- Job-Adjustments"

I could be really wrong about this, but it seems simple to do like addMod(MOD_ATTP) to player after call wyvern and delete them after dismiss/wyvern's death? Oh.. but the increments...hmm

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <github/DarkstarProject/darkstar - Issue 3744>, or mute the thread <github/notifications/unsubscribe-auth/ABGI_24SvP_8yI82YC5P6wPwPXi3mzAyks5rfR9vgaJpZM4MJk2Y> .

topaz-bot commented 4 years ago

Comment by Hozu Thursday Feb 23, 2017 at 16:25 GMT


I believe those buffs are being applied to the wyvern itself, currently. I thought that's how it was supposed to be? Didn't think the buffs were to the player itself...

topaz-bot commented 4 years ago

Comment by teschnei Thursday Feb 23, 2017 at 17:00 GMT


2014 change

On Feb 23, 2017 9:25 AM, "Hozu" wrote:

I believe those buffs are being applied to the wyvern itself, currently. I thought that's how it was supposed to be? Didn't think the buffs were to the player itself...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <github/DarkstarProject/darkstar - Issue 3744Darkstar Issue issuecomment-282042385>, or mute the thread <github/notifications/unsubscribe-auth/ABGI_xmVgGq8EpGogf17vrvWE4WDa1A2ks5rfbLigaJpZM4MJk2Y> .