claim/enmity issues for charmed pets

Issue by Wiggo32 Saturday Nov 18, 2017 at 00:51 GMT Originally opened as DarkstarProject/darkstar - Issue 4240

I have:

[x] searched existing issues (http://github.com/darkstarproject/darkstar - Issue ) to see if the issue I am posting has already been addressed or opened by another contributor
[x] checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) : 30170905_5

Server Version (type !revision in game) : unknown

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) :

Just tested out retail BST here are some issues needing addressing for dsp:

When pets 'uncharm' they should come completely off the enmity list of the mob which they were attacking. The 'attacked' mob does not retain memory of enmity toward a mob that was once charmed.
a BST and his PET cannot both hold claim on their own mob. Only 1 mob can be claimed between the two of them. How I watched this working was: BST attacking a mob while PET attacking a different mob, when the pet hit the mob it turned red and the BST mob turned yellow, when the BST hit, his mob turned red and the PET's mob turned yellow. There was never two mobs red at the same time even for a split second.
PET has its own enmity list and acts off of it according to which mob generates the most enmity.
- first scenerio: PET ordered to fight a mob, then ordered to fight a different mob, pet would switch focus between the two mobs depending on who hit the hardest or generated the most enmity basically. and still only 1 mob could be red at a time.
- second scenerio: PET ordered to fight a mob, then was attacked by a link without any other provocation. as linked mob generated enough enmity it caused PET to switch focus from the originally attacked mob to the linked mob. and still only 1 mob could be red at a time.

project-topaz / topaz