project-topaz / topaz

Server emulator for FFXI
Other
159 stars 224 forks source link

Earthbreaker shouldn't wipe shadows like AOE magic #279

Open topaz-bot opened 4 years ago

topaz-bot commented 4 years ago

Issue by isotor Thursday Apr 18, 2019 at 13:23 GMT Originally opened as DarkstarProject/darkstar - Issue 5865


I have:

Client Version (type /ver in game) : 30190328_2

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) :

Weird one since it's a magical AOE move, right?

I vaguely tried to take a crack at submitting this directly as a PR but I'm not quite sure how to update. Earthbreaker is currently defined as a [MobMagicalMove](github/DarkstarProject/darkstar/blob/230ab12088d288122c3414757ff74e0f25a3d61b/scripts/globals/mobskills/earthbreaker.luaDarkstar Issue L24) with param WIPE_SHADOWS when it should be work like a multihit AOE using something like numhits.

I found a video showing Earthbreaker being absorbed by shadows twice, timestamped here: https://youtu.be/hy3GPJc3kEw?t=128 (turn your volume down) https://youtu.be/hy3GPJc3kEw?t=407

Not sure how many the max numhits should be, though if I had to bet I'd go with 3 or 5. Any help on how to slide this parameter into a MagicalMove would be appreciated.

Oh, and you can chalk up the inaccuracy to Darkstar Issue wikifails TeoTwawki

topaz-bot commented 4 years ago

Comment by isotor Thursday Apr 18, 2019 at 13:24 GMT


Related: unsure if this same issue should apply to it's little brother Earth Pounder but I rather strongly suspect it does.