search

project-topaz / topaz

Server emulator for FFXI
Other
162 stars 223 forks source link

ATTACK_BREATH is unused, possibly by design. #377

Open mrhappyasthma opened 4 years ago

mrhappyasthma commented 4 years ago

There's an ATTACK_BREATH enum value (and similar one in Lua). But it's not used anywhere.

It's possible this may not be needed, since most breath spells are listed as "magical" by most FFXI websites. e.g. "heat breath" is labeled as "fire" + "magical". (https://ffxiclopedia.fandom.com/wiki/Heat_Breath)

Although if it was intended to be used for something, it's not.

https://github.com/DarkstarProject/darkstar/blob/master/src/map/entities/battleentity.h#L244

https://github.com/DarkstarProject/darkstar/blob/master/scripts/globals/status.lua#L2123

mrhappyasthma commented 4 years ago

I'm in the process of updating the attackType for all blu spells. I'm going to follow the convention of labeling them as MAGICAL for now.

If we decide this is something we want used, I can go through and change the breath spells to BREATH.

(For context: https://github.com/project-topaz/topaz/issues/314)

mrhappyasthma commented 4 years ago

Per discussion with the appropriate stakeholders, Breath spells will be fixed in the future to have proper damage calculations. I'll update my outstanding PR to label the breath spells as such in preparation for that.

mrhappyasthma commented 4 years ago

Issue to fix breath damage calculation appears to be here: https://github.com/project-topaz/topaz/issues/239