Closed Swati4star closed 6 years ago
I would like to work on this!
You want to pick up https://github.com/project-travel-mate/Travel-Mate/issues/121 or this one first?
I will go with #121 first.
Would like to work on this, if @syedjahangirpeeran isn't working on it
Yes you can. He is working on user profile page right now.
This is a rough display of World Clock
in Utilities
.
First I will be arranging the cities according to names and each of the rows will be filled with the name of the city and the current digital time.
Second on clicking one of the rows of the World Clock
, an analog clock along with the weather report will be diaplyed.
@Swati4star , could you please review the deisgn and check whether I should go with this design?
@Pritom14
On the second page, don't show the weather report
Show analog clock
, time in digital format
, day
,
...and other information like, how ahead/behind is it as compared to my current time zone.
Other than this, it looks great. 👍
Okay, so, where do I show the weather report? And will this design be good?
This is just world clock. You don't need to show weather report here. and this design does look good 👍
Okay, I will start working on it.
@Swati4star , this is the final design of the World Clock
, could you please review it.
The only problem is that, the analog clock
shows only the current time and cannot be customised to take user input. Is there any library for thatcustomising the analog clock
so that it takes user input?
@Pritom14 Good word! Here are some UI suggestions: First screen :
Also, I guess the color of top bar is not same as our app's primary color.
This is just a sample app I created before integrating the features onto the main application.
I will see to it that the gap size is less and will take care of the margin
Regarding the analog clock, the analog clock in android cannot be customised. There is no function
called analog.setTime()
. It will only display the current time.
The only option to display the analog clock
is to create a custom analog clock
using canvas
. But
the UI will be plain simple
Create a custom analog clock. We'll be able to customize UI according to our needs. ( The UI will still be better than the default clock provided :p )
I will start working on it, and post the UI screenshots over here
@Swati4star , will it be a problem if we create a different issue for displaying the analog clock
, coz I've tried a lot of things but I am unable to display the analog clock
with different time?
Sure. Then, just keep the analog clock view as you posted in the previous screenshot
@Swati4star , the spaces between the list items cannot be reduced as because they have a cardview
layout. If card view
layout is not used then the spacing between list items becomes less. I have attached two screenshots with and without using cards, could you please let me know which to implement
The spacing is too much. Look into the following page: https://github.com/project-travel-mate/Travel-Mate/blob/master/screenshots/trend.png
Make your UI like the first one, but with a divider line
Okay
On Sat 30 Jun, 2018, 1:07 PM Swati Garg, notifications@github.com wrote:
The spacing is too much. Look into the following page:
https://github.com/project-travel-mate/Travel-Mate/blob/master/screenshots/trend.png
Make your UI like the first one, but with a divider line
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/project-travel-mate/Travel-Mate/issues/117#issuecomment-401524236, or mute the thread https://github.com/notifications/unsubscribe-auth/APzU4l7YlTWNQDo9roB2E89j_dun1Uasks5uByqogaJpZM4U1Ewp .
@Pritom14 Status?
Working on it
I have removed the image from the list view
row as it was taking up much space. Could you please review it?
The images were looking good.
Left align the names.
Images were looking good but it was taking up to much space, and also because I couldn't use android:drawableLeft
, so I left out the images.
Apart from aligning the names to the left, are the layouts okay? @Swati4star
Without the images and analog clock, the UI is not at all looking good.
In each list item:
Mon 2 Jul
10:48pm
..and on clicking, just open up a dialog will all this info!
Could you please have a look at these, I just edited the fonts and added the images back in the list view.
If the layouts are still not looking good, I will start working on displaying info on the dialog part
On Mon 2 Jul, 2018, 10:49 PM Swati Garg, notifications@github.com wrote:
..and on clicking, just open up a dialog will all this info!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/project-travel-mate/Travel-Mate/issues/117#issuecomment-401874458, or mute the thread https://github.com/notifications/unsubscribe-auth/APzU4uj14azrb4JDbiYep_DU8iIwj2Q6ks5uClYVgaJpZM4U1Ewp .
@Pritom14 You haven't added any screenshots.
The second one looks good. I hope, the images are not causing that much problem.
I had to resize all the images, so now it should be okay.
Awesome :)
So, if the layout is good enough, can I start creating the PR? And also do I have to create a dialog to display the info now, or the second layout where the text clock along with the timezone is displayed is okay?
It's okay. I'll create a different issue to add analog clock there.
Okay, I will start working on adding the features on the main application.
Closing this because of a lot of spam.
Add a new option in utilities :
World Clock