search

project-travel-mate / Travel-Mate

A complete travel guide!
https://project-travel-mate.github.io
MIT License
1.29k stars 907 forks source link

The page loses functionality while fetching data #569

Open ShivangiSingh17 opened 5 years ago

ShivangiSingh17 commented 5 years ago

The information displayed regarding cities under Know more about in the application is fetched form wikimedia that uses the text to speech feature for the city names pronounciation. But in the application the feature is missing and only listen word is displayed without the sound feature.

Steps to reproduce

Choose cities like Bangalore, Chennai, Kolkata, Jaipur, Hyderabad, Ahmedabad and when we click to know more about these cities we see (listen) word displayed without the pronunciation functionality available.

Expected behaviour

It should have the pronunciation available when the user click on listen

Actual behaviour

Only listen word is displayed without any pronunciation .

Would you like to work on the issue?

Yes

ShivangiSingh17 commented 5 years ago

@Swati4star @thedevelopersanjeev I would like to implement this missing feature. Shall I start working on this issue?

Swati4star commented 5 years ago

@ShivangiSingh17 you are working on https://github.com/project-travel-mate/Travel-Mate/issues/570 also. complete that, and then you may start on this

ShivangiSingh17 commented 5 years ago

Ok sure, @Swati4star I will first work on #570 then I will continue doing this one.

atul161 commented 5 years ago

I am going to start this!!

ShivangiSingh17 commented 5 years ago

@atul161 I am already working on this.

atul161 commented 5 years ago

ohkk

atul161 commented 5 years ago

@ShivangiSingh17 i have worked in this and i found that "you cant stop Text to speech which is running in background(tts.stop(),tts.shutdown()) fails for some Android devices and also worked for some devices " .so there is one more option you can record that audio and save in room database and after saving we can play pause and Perform other operation on recorded Audio.If you have done this please let me know!!

ShivangiSingh17 commented 5 years ago

@atul161, I am not solving this issue as suggested by you. I am removing that whole function while fetching and will show the data only.

OlgaMorales commented 5 years ago

@ShivangiSingh17 Can i work on this issue?

ShivangiSingh17 commented 5 years ago

I am already working on this issue and I am almost done, I am facing an error. Once done, I will be sending a PR soon.

Warm regards Shivangi Singh

On Tue, Apr 23, 2019, 9:45 AM OlgaMorales <notifications@github.com wrote:

@ShivangiSingh17 https://github.com/ShivangiSingh17 Can i work on this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/project-travel-mate/Travel-Mate/issues/569#issuecomment-485637184, or mute the thread https://github.com/notifications/unsubscribe-auth/AKOMAJG3CSSHJUNN7BQAFFLPR2EPVANCNFSM4G3MVRCQ .

Swati4star commented 5 years ago

@ShivangiSingh17 Fix this first