project-travel-mate / server

Django server for Travel Mate (Project: nomad)
https://project-travel-mate.github.io
MIT License
47 stars 65 forks source link

[API Request] GET API for currency convertor #27

Closed prabhakar267 closed 6 years ago

prabhakar267 commented 6 years ago

Using The Free Currency Converter API make a GET API that takes two currencies, source_currency and target_currency and make a call to the API and render the conversion rate as output

arunikayadav42 commented 6 years ago

Can I get started with this issue please :)

arunikayadav42 commented 6 years ago

Also if you could help me get started Like I only know a bit of django and am still learning the same so any help would be appreciated...

arunikayadav42 commented 6 years ago

@prabhakar267 also on this issue..can I work on this issue too :)

prabhakar267 commented 6 years ago

@arunikayadav42 You complete one issue, then you can pick other 👍 We have a plenty of issues, don't worry

darthgera123 commented 6 years ago

is this issue assigned or can i work on this?

prabhakar267 commented 6 years ago

@darthgera123 you can work on this

arunikayadav42 commented 6 years ago

@prabhakar267 actually this was a good first issue so I wanted to start off with this one if it's alright :)

arunikayadav42 commented 6 years ago

Moreover @prabhakar267 I have already started working on this one so if you could please offer @darthgera123 some other issue :)

prabhakar267 commented 6 years ago

@arunikayadav42 please claim only one issue at a time Once you fix that or release it for someone else, then only claim another one There are a lot of people wanting to work on the project, let's maintain the basic OSS courtesy Thanks

Making an exception for this time since you have started working on the issue. You would have to complete this issue before you claim any other issue. PRs by you for any other issues would be rejected right away.

For @darthgera123 , you can pick #24 No one is working on that 😄 /cc @Swati4star

darthgera123 commented 6 years ago

no problem

arunikayadav42 commented 6 years ago

@prabhakar267 when I am trying to run python manage.py test it gives me the following error. screenshot from 2018-06-27 02-58-45 Please help me.

arunikayadav42 commented 6 years ago

@prabhakar267 any comments on the above error ?

prabhakar267 commented 6 years ago

@arunikayadav42 I faced the same issue, I don't remember exactly what I did to fix it You can have a look at this answer https://stackoverflow.com/a/14186439/5602759 I remember this solved my problem

prabhakar267 commented 6 years ago

@arunikayadav42 updates?

arunikayadav42 commented 6 years ago

I am still trying to dealing with that error....

prabhakar267 commented 6 years ago

Ping me on slack

darthgera123 commented 6 years ago

its simple you can log into the postgres shell and type ALTER USER nomad CREATEDB; and it works like a charm

arunikayadav42 commented 6 years ago

I will try to look into it again today :)

prabhakar267 commented 6 years ago

@darthgera123 can you raise a PR with this in README?

arunikayadav42 commented 6 years ago

Can I raise it?

darthgera123 commented 6 years ago

sure

arunikayadav42 commented 6 years ago

Can somebody tell me that even after running localhost:8000 in the browser I dont see anything running.why is it so?

arunikayadav42 commented 6 years ago

@prabhakar267 I need your help please how do I connect with you on slack please let me know!

arunikayadav42 commented 6 years ago

Also does it have to be a separate api directory or will it be inserted in the views.py module of existing apis?

prabhakar267 commented 6 years ago

@arunikayadav42 are you working on this as a part of GSSoC? If so you would have had gotten a invitation for slack channel If not, you can ping me on Hangouts (prabhakargupta267@gmail.com)