search

project-zot / helm-charts

7 stars 19 forks source link

feat: ability to choose specific service nodePort #15

Closed Frostman closed 1 year ago

Frostman commented 1 year ago

While using service type=LB, it's very useful to choose a specific nodePort (instead of having a random one assigned).

https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport

rchincha commented 1 year ago

@Frostman thanks for your PR. Pls. take a look at the CI failures.

rchincha commented 1 year ago

@Frostman let us know if you can work on this PR, else we can take over.

Frostman commented 1 year ago

@rchincha I'll fix it

Frostman commented 1 year ago

@rchincha could you please have a look? I think I've fixed. Error in helm-chart-release wasn't related to the PR (looks like).

rchincha commented 1 year ago

@rchincha could you please have a look? I think I've fixed. Error in helm-chart-release wasn't related to the PR (looks like).

https://github.com/project-zot/helm-charts/pull/12/files#diff-01100e283df60824b81840c912c502dd3001951f15534e0a4c734b5b76356750

@Frostman need a version bump like so ^

rchincha commented 1 year ago

https://github.com/project-zot/helm-charts/pull/18 ^ was just merged, would rebase and bump the version to .31

rchincha commented 1 year ago

@Frostman pls apply this patch as well.

diff --git a/charts/zot/Chart.yaml b/charts/zot/Chart.yaml
index 62a3b3d..16f5346 100644
--- a/charts/zot/Chart.yaml
+++ b/charts/zot/Chart.yaml
@@ -3,4 +3,4 @@ appVersion: v2.0.0-rc6
 description: A Helm chart for Kubernetes
 name: zot
 type: application
-version: 0.1.30
+version: 0.1.31
rchincha commented 1 year ago

Closing this since commit included as part of PR #19