search

project-zot / helm-charts

7 stars 18 forks source link

feat: auto restart deployment when config files change #36

Closed zhming0 closed 7 months ago

zhming0 commented 7 months ago

What type of PR is this?

feature

What does this PR do / Why do we need it:

This PR ensure when the configFiles changes and mountConfig is true, zot deployment will be automatically restarted.

This will eliminate the manual zot restart step after config change.

This is done per helm's official best practice guide.

Testing done on this change:

Unit test added.

Automation added to e2e:

N/A

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

Changing config files will now automatically restart Zot's deployment.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rchincha commented 7 months ago

@Andreea-Lupu pls review. This is a good PR to have. Thanks @zhming0.

rchincha commented 7 months ago

@zhming0 pls also fix the CI failures.

zhming0 commented 7 months ago

@rchincha done, please re-run the CI 🙏🏿 .

zhming0 commented 7 months ago

@rchincha please run the CI one more time 🙏🏿 , this time should pass. Sorry for the trouble.

rchincha commented 7 months ago

Thanks @zhming0 @Andreea-Lupu pls also review.