search

project-zot / project-zot.github.io

zotregistry.dev website
https://zotregistry.dev
Apache License 2.0
3 stars 20 forks source link

correct the callback url #153

Closed cboettig closed 9 months ago

cboettig commented 9 months ago

Fix for https://github.com/project-zot/zot/issues/2191

Callback URL syntax path is incorrect, misses the zot/. Correct path is given in: https://github.com/project-zot/zot/blob/9def35f3b8b38f5a438146a09087edcec00537c7/examples/README.md?plain=1#L294

What type of PR is this?

documentation

Which issue does this PR fix:

Fix for https://github.com/project-zot/zot/issues/2191

What does this PR do / Why do we need it:

Callback URL is incorrect in docs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

andaaron commented 9 months ago

Thank you for the contribution. The diff looks good, please make these changes to the commit and push again:

git commit --amend -s -S to prepend docs: to the first line of the commit message, add the signoff email and GPG sign the commit.

rchincha commented 9 months ago

@cboettig pls address the CI failures.

cboettig commented 9 months ago

sorry for the delay, my signing key expired so I had to retrieve the offline master key to renew my subkey, oof :lock: let me know if that fixes the commit formatting and thanks @andaaron for the clear instructions!

andaaron commented 9 months ago

sorry for the delay, my signing key expired so I had to retrieve the offline master key to renew my subkey, oof 🔒 let me know if that fixes the commit formatting and thanks @andaaron for the clear instructions!

Hi, the process itself was ok, but it seems there's a mismatch between the names used: sign-off not found for commit author: Carl Boettiger cboettig@gmail.com; found: ['Carl <cboettig@gmail.com>']

Is the git user.name setting the same as the one configured for GPG?

cboettig commented 9 months ago

thanks fixed.