search

project-zot / zot

zot - A scale-out production-ready vendor-neutral OCI-native container image/artifact registry (purely based on OCI Distribution Specification)
https://zotregistry.dev
Apache License 2.0
963 stars 100 forks source link

Catalog content discovery #2782

Open eusebiu-constantin-petu-dbk opened 2 weeks ago

eusebiu-constantin-petu-dbk commented 2 weeks ago

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 83.58974% with 32 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (5e30fec) to head (7afee3d).

Files with missing lines Patch % Lines
pkg/extensions/sync/remote.go 31.81% 14 Missing and 1 partial :warning:
pkg/storage/imagestore/imagestore.go 82.81% 8 Missing and 3 partials :warning:
pkg/api/authz.go 66.66% 2 Missing and 1 partial :warning:
pkg/api/routes.go 96.15% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2782 +/- ## ========================================== - Coverage 91.93% 91.88% -0.06% ========================================== Files 170 170 Lines 30126 30282 +156 ========================================== + Hits 27697 27824 +127 - Misses 1806 1829 +23 - Partials 623 629 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

uvegla commented 2 weeks ago

I gave it a try and found some problem I think. I updated the original issue: https://github.com/project-zot/zot/issues/2715#issuecomment-2478903426 and will take a deeper look.

rchincha commented 1 week ago

Also be mindful about access control - one may not have read access to all repos.

eusebiu-constantin-petu-dbk commented 6 days ago

@uvegla Thank you very much for your work on this! Can you try it again please?

uvegla commented 2 days ago

Tested locally, looks good to me now! 🙂 Thank you for working on this! 👍🏻