project-zot / zui

UI for zot registry
Apache License 2.0
13 stars 21 forks source link

fix: login bug when both anonymous and auth is enabled #358

Closed raulkele closed 1 year ago

raulkele commented 1 year ago

What type of PR is this? bug

Which issue does this PR fix: Closes #357

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 1 year ago

Codecov Report

Merging #358 (dd3b046) into main (936590d) will decrease coverage by 0.71%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   90.36%   89.66%   -0.71%     
==========================================
  Files          50       50              
  Lines        1422     1422              
  Branches      355      357       +2     
==========================================
- Hits         1285     1275      -10     
- Misses        128      138      +10     
  Partials        9        9              
Impacted Files Coverage Δ
src/components/Login/SignIn.jsx 96.29% <66.66%> (-1.24%) :arrow_down:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more