codecov[bot]
commented
1 year ago Codecov Report
Merging #366 (30bd552) into main (8086f68) will increase coverage by
0.23%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 86.87% 87.11% +0.23%
==========================================
Files 52 51 -1
Lines 1516 1513 -3
Branches 381 382 +1
==========================================
+ Hits 1317 1318 +1
+ Misses 189 185 -4
Partials 10 10 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/api.js | 69.13% <100.00%> (+0.38%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
What type of PR is this?
bug
Which issue does this PR fix: Closes #363
What does this PR do / Why do we need it: Zui has logic to logout user and send them to login page if an unauthorized response is received from the zot server, this logic was also applying on the signin page, which caused the sigin page to refresh if login failed(because of wrong credentials for eg). This pr adds exception to the unauthorized response handler
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.