project-zot / zui

UI for zot registry
Apache License 2.0
13 stars 21 forks source link

patch: signature display redesign #388

Closed raulkele closed 7 months ago

raulkele commented 1 year ago

What type of PR is this? feature

Which issue does this PR fix: Closes #383

What does this PR do / Why do we need it: Implements changes to signature display. Redesign signature related component logic

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

- Take advantage of new SignatureInfo property from the backend
- Removed IsSigned usage in favor of SignatureInfo
- Displays strongest signature for each tool (cosign, notation)
- Details page displays all signatures
- Introduced different chip for signed but not trusted (Yellow icon)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 1 year ago

Codecov Report

Merging #388 (494efdc) into main (fad5572) will decrease coverage by 0.48%. The diff coverage is 70.17%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   86.73%   86.26%   -0.48%     
==========================================
  Files          53       53              
  Lines        1553     1587      +34     
  Branches      416      426      +10     
==========================================
+ Hits         1347     1369      +22     
- Misses        193      206      +13     
+ Partials       13       12       -1     
Files Coverage Δ
src/components/Explore/Explore.jsx 90.90% <ø> (ø)
src/components/Home/Home.jsx 100.00% <ø> (ø)
src/components/Shared/PreviewCard.jsx 100.00% <100.00%> (ø)
src/components/Shared/RepoCard.jsx 100.00% <100.00%> (ø)
src/components/Tag/Tabs/DependsOn.jsx 92.85% <ø> (ø)
src/components/Tag/Tabs/IsDependentOn.jsx 92.85% <ø> (ø)
src/utilities/filterConstants.js 100.00% <100.00%> (ø)
src/utilities/objectModels.js 86.95% <ø> (+13.04%) :arrow_up:
src/components/Repo/RepoDetails.jsx 97.26% <77.77%> (-2.74%) :arrow_down:
src/components/Tag/TagDetails.jsx 94.73% <60.00%> (-2.45%) :arrow_down:
... and 3 more

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

raulkele commented 7 months ago

Picked up and superseded by #427